launchpad-reviewers team mailing list archive

[Guruprasad <mp+415250@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/model/bugtask.py b/lib/lp/bugs/model/bugtask.py
> index 7b31d6d..b468c5e 100644
> --- a/lib/lp/bugs/model/bugtask.py
> +++ b/lib/lp/bugs/model/bugtask.py
> @@ -358,8 +358,8 @@ def validate_target(bug, target, retarget_existing=True,
>              try:
>                  target.distribution.guessPublishedSourcePackageName(
>                      target.sourcepackagename.name)
> -            except NotFoundError as e:
> -                raise IllegalTarget(e.args[0])
> +            except NotFoundError:
> +                return BugTaskStatus.DOES_NOT_EXIST

I am not entirely sure why we should return `BugTaskStatus.DOES_NOT_EXIST` when the `guessPublishedSourcePackageName()` method returns a `NotFoundError` exception. Isn't the purpose of this status to denote that a bug does not exist in a specific bug target series?

>  
>      legal_types = target.pillar.getAllowedBugInformationTypes()
>      new_pillar = target.pillar not in bug.affected_pillars


-- 
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/415250
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:add-dne-bug-task-status into launchpad:master.