launchpad-reviewers team mailing list archive

[Colin Watson <mp+415819@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad-buildd:unpin-python-debian into launchpad-buildd:master.

Commit message:
Unversion python-debian requirement

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/+git/launchpad-buildd/+merge/415819

The minimum version required was very old (pre-xenial), so the version constraint was no longer really necessary.  Furthermore, the version of the packaged python-debian in >= focal confuses modern pip/setuptools (see https://bugs.launchpad.net/bugs/1926870); removing the version constraint avoids needing to care about this.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-buildd:unpin-python-debian into launchpad-buildd:master.

diff --git a/debian/changelog b/debian/changelog
index 355fb51..5ff6c3c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ launchpad-buildd (209) UNRELEASED; urgency=medium
 
   * Upgrade charm to bionic and Python 3.
   * Remove Python 2 support.
+  * Unversion python-debian requirement, since the minimum version required
+    was very old (pre-xenial) and the version of the packaged python-debian
+    confuses modern pip/setuptools (see
+    https://bugs.launchpad.net/bugs/1926870).
 
  -- Colin Watson <cjwatson@xxxxxxxxxx>  Thu, 10 Feb 2022 09:27:28 +0000
 
diff --git a/setup.py b/setup.py
index 559d9a4..680e2c5 100755
--- a/setup.py
+++ b/setup.py
@@ -70,7 +70,7 @@ setup(
         # that's normally shipped as a system package and specifying it here
         # causes problems for Launchpad's build system.
         # 'python-apt',
-        'python-debian>=0.1.23',
+        'python-debian',
         'requests',
         'six',
         'Twisted',