launchpad-reviewers team mailing list archive

[Colin Watson <mp+415846@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad-buildd:dnsmasq-base-dependency into launchpad-buildd:master.

Commit message:
Depend on dnsmasq-base

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/+git/launchpad-buildd/+merge/415846

The LXD backend needs this (it uses /usr/sbin/dnsmasq to set up a bridge interface), but it's no longer in cloud images as of focal.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-buildd:dnsmasq-base-dependency into launchpad-buildd:master.

diff --git a/debian/changelog b/debian/changelog
index 5ff6c3c..ccbc481 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,8 @@ launchpad-buildd (209) UNRELEASED; urgency=medium
     was very old (pre-xenial) and the version of the packaged python-debian
     confuses modern pip/setuptools (see
     https://bugs.launchpad.net/bugs/1926870).
+  * Depend on dnsmasq-base.  The LXD backend needs this, but it's no longer
+    in cloud images as of focal.
 
  -- Colin Watson <cjwatson@xxxxxxxxxx>  Thu, 10 Feb 2022 09:27:28 +0000
 
diff --git a/debian/control b/debian/control
index 25cc5f1..fa626c2 100644
--- a/debian/control
+++ b/debian/control
@@ -42,6 +42,7 @@ Depends: adduser,
          bzip2,
          debootstrap,
          dmsetup,
+         dnsmasq-base,
          dpkg-dev,
          file,
          lsb-release,