launchpad-reviewers team mailing list archive

[Guruprasad <mp+416656@xxxxxxxxxxxxxxxxxx>]

> > I have already run the linters locally before I created this merge proposal
> and did not see any linter errors. Did you see any issues?
> 
> 
> Yes.
> 
> ```
> $ tox -e lint

> ```

I ran `tox -e lint` before commit and the pre-commit hooks ran as well and there were no errors reported.

[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.                                                                                                            
[INFO] Once installed this environment will be reused.                                                                                                                                       
[INFO] This may take a few minutes...                                                                                                                                                        
[INFO] Installing environment for https://github.com/PyCQA/flake8.                                                                                                                           
[INFO] Once installed this environment will be reused.                                                                                                                                       
[INFO] This may take a few minutes...                                                                                                                                                        
[INFO] Installing environment for https://github.com/psf/black.                                                                                                                              
[INFO] Once installed this environment will be reused.                                                                                                                                       
[INFO] This may take a few minutes...                                                                                                                                                        
Check for added large files..............................................Passed                                                                                                              
Check python ast.........................................................Passed                                                                                                              
Check for merge conflicts................................................Passed                                                                                                              
Check Yaml...........................................(no files to check)Skipped                                                                                                              
Debug Statements (Python)................................................Passed                                                                                                              
Fix End of Files.........................................................Passed                                                                                                              
Trim Trailing Whitespace.................................................Passed                                                                                                              
flake8...................................................................Passed                                                                                                              
isort....................................................................Passed                                                                                                              
black....................................................................Passed                                                                                                              
setup-cfg-fmt........................................(no files to check)Skipped                                                                                                              
hint: Waiting for your editor to close the file...                                                                                                                                           
Waiting for Emacs...                                                                                                                                                                         
[add-clean-command-clean-flag 59c6d76] Implement the clean command and the clean flag to the run commands                                                                                    
 Date: Thu Mar 10 15:48:29 2022 +0530                                                                                                                                                        
 6 files changed, 420 insertions(+), 82 deletions(-)                                                                                                                                         
 create mode 100644 lpcraft/commands/clean.py                                                                                                                                                
 create mode 100644 lpcraft/commands/tests/test_clean.py    

So I am not sure what happened and why the linter did not show the errors for me.

Checking and fixing the issues now.                                                                                                                                 
-- 
https://code.launchpad.net/~lgp171188/lpcraft/+git/lpcraft/+merge/416656
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/lpcraft:add-clean-command-clean-flag into lpcraft:main.