launchpad-reviewers team mailing list archive

[Guruprasad <mp+416744@xxxxxxxxxxxxxxxxxx>]

Should running the plain `tox` command run the unit tests twice - once each for the unit test environment and once for the coverage environment. The latter is sufficient to cover both needs, right?

Diff comments:

> diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
> index e4c23d1..64753c6 100644
> --- a/CONTRIBUTING.rst
> +++ b/CONTRIBUTING.rst
> @@ -6,8 +6,6 @@ Prerequisites
>  
>  * Python 3.8+
>  * `tox <https://tox.wiki/en/latest/>`_
> -* `pyenv <https://github.com/pyenv/pyenv>`_, if you want to use and test against
> -  multiple versions of Python

Can we rephrase this to mention that other supported Python versions can be installed as needed? I am mentioning this because `Python 3.8+` doesn't imply that more than one version of Python might be necessary - we do need 3.8 and 3.9 for some tox environments.

>  
>  Usage
>  -----


-- 
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/416744
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/lpcraft:improve-contribution-documentation into lpcraft:main.