launchpad-reviewers team mailing list archive

[Colin Watson <mp+417039@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:rename-cron-base-ppa into launchpad:master.

Commit message:
Rename cron.base-ppa to cron.base-ppa.sh

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/417039

This causes https://github.com/pre-commit/identify to identify it as `shell` rather than as just a generic text file, which will shortly be useful for adding a `shellcheck` pre-commit hook.

I also removed the `#!` line from this file; since the file is non-executable and only ever processed by sourcing it into other shell scripts, there's no point in it having a `#!` line to tell the kernel how to execute it.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:rename-cron-base-ppa into launchpad:master.

diff --git a/cronscripts/publishing/cron.base-ppa b/cronscripts/publishing/cron.base-ppa.sh
similarity index 95%
rename from cronscripts/publishing/cron.base-ppa
rename to cronscripts/publishing/cron.base-ppa.sh
index e89a912..f9d8d70 100644
--- a/cronscripts/publishing/cron.base-ppa
+++ b/cronscripts/publishing/cron.base-ppa.sh
@@ -1,5 +1,3 @@
-#!/bin/bash
-#
 # Copyright 2009 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
diff --git a/cronscripts/publishing/cron.daily-ppa b/cronscripts/publishing/cron.daily-ppa
index 9ec108f..20b1d74 100755
--- a/cronscripts/publishing/cron.daily-ppa
+++ b/cronscripts/publishing/cron.daily-ppa
@@ -10,7 +10,7 @@ set -x
 LOCKFILEOPTIONS="-r-1"
 
 # Variables, lockfile and exit handler for PPA scripts.
-source `dirname $0`/cron.base-ppa
+source `dirname $0`/cron.base-ppa.sh
 
 # Clear out empty and thus redundant dirs.
 find $PPAROOT -type d -empty | xargs -r rmdir
diff --git a/cronscripts/publishing/cron.publish-ppa b/cronscripts/publishing/cron.publish-ppa
index 763f35a..81ed9b1 100755
--- a/cronscripts/publishing/cron.publish-ppa
+++ b/cronscripts/publishing/cron.publish-ppa
@@ -6,7 +6,7 @@
 set -x
 
 # Variables, lockfile and exit handler for PPA scripts.
-source `dirname $0`/cron.base-ppa
+source `dirname $0`/cron.base-ppa.sh
 
 LPCURRENT=`dirname $0`/../..