launchpad-reviewers team mailing list archive

[Colin Watson <mp+417739@xxxxxxxxxxxxxxxxxx>]

Review: Approve db



Diff comments:

> diff --git a/database/schema/patch-2210-45-0.sql b/database/schema/patch-2210-45-0.sql
> new file mode 100644
> index 0000000..a505fe0
> --- /dev/null
> +++ b/database/schema/patch-2210-45-0.sql
> @@ -0,0 +1,14 @@
> +-- Copyright 2022 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +ALTER TABLE BugTask
> +    ADD COLUMN status_explanation text,
> +    ADD COLUMN importance_explanation text;
> +
> +COMMENT ON COLUMN BugTask.status_explanation IS 'The explanation for the current status of this bugtask.';
> +
> +COMMENT ON COLUMN BugTask.importance_explanation IS 'The explanation for the current importance of this bugtask.';

Maybe "An optional explanation ..." in both cases?

> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 45, 0);


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/417739
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:bugtask-changes-sql into launchpad:db-devel.