launchpad-reviewers team mailing list archive

[Zygmunt Krynicki <mp+419405@xxxxxxxxxxxxxxxxxx>]

Small question about when the new logic triggers.

Diff comments:

> diff --git a/lib/lp/code/model/gitref.py b/lib/lp/code/model/gitref.py
> index 08bb3bc..7a0d828 100644
> --- a/lib/lp/code/model/gitref.py
> +++ b/lib/lp/code/model/gitref.py
> @@ -924,6 +950,9 @@ class GitRefRemote(GitRefMixin):
>                  len(url.path.strip("/").split("/")) == 2):
>              return _fetch_blob_from_github(
>                  self.repository_url, self.path, filename)
> +        if url.hostname == "gitlab.com":

Would it makes sense to include some well-known gitlab instances here? Freedesktop, Gnome, Eclipse, etc?

> +            return _fetch_blob_from_gitlab(
> +                self.repository_url, self.path, filename)
>          if (url.hostname == "git.launchpad.net" and
>                  config.vhost.mainsite.hostname != "launchpad.net"):
>              # Even if this isn't launchpad.net, we can still retrieve files


-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/419405
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:gitlab-blob into launchpad:master.