launchpad-reviewers team mailing list archive

[Colin Watson <mp+419500@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:soyuz-sampledata-setup-jammy into launchpad:master.

Commit message:
Expand docstring for create_sections

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/419500

This was in response to review comments on https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/417862 and was supposed to be landed along with the rest of that MP, but it looks like perhaps I accidentally approved the wrong revision for landing.  I found this when going through my local branches.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:soyuz-sampledata-setup-jammy into launchpad:master.

diff --git a/utilities/soyuz-sampledata-setup.py b/utilities/soyuz-sampledata-setup.py
index bf5b56d..71642cf 100755
--- a/utilities/soyuz-sampledata-setup.py
+++ b/utilities/soyuz-sampledata-setup.py
@@ -153,13 +153,20 @@ def add_architecture(distroseries, architecture_name):
 
 
 def create_sections(distroseries):
-    """Set up some sections for `distroseries`."""
+    """Set up some sections for `distroseries`.
+
+    These are kept roughly in sync with production, which in turn is
+    typically kept roughly in sync with the Debian archive (compare
+    https://www.debian.org/doc/debian-policy/ch-archive.html#sections).  The
+    list here is only a convenience for local development, so it isn't vital
+    for it to be precisely accurate.
+    """
     section_names = (
-        'admin', 'cli-mono', 'comm', 'database', 'devel', 'debug', 'doc',
+        'admin', 'cli-mono', 'comm', 'database', 'debug', 'devel', 'doc',
         'editors', 'education', 'electronics', 'embedded', 'fonts', 'games',
-        'gnome', 'golang', 'graphics', 'gnu-r', 'gnustep', 'hamradio',
+        'gnome', 'gnu-r', 'gnustep', 'golang', 'graphics', 'hamradio',
         'haskell', 'httpd', 'interpreters', 'java', 'javascript', 'kde',
-        'kernel', 'libs', 'libdevel', 'lisp', 'localization', 'mail',
+        'kernel', 'libdevel', 'libs', 'lisp', 'localization', 'mail',
         'math', 'misc', 'net', 'news', 'ocaml', 'oldlibs', 'otherosfs',
         'perl', 'php', 'python', 'raku', 'ruby', 'rust', 'science',
         'shells', 'sound', 'tex', 'text', 'utils', 'vcs', 'video', 'web',