← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~jugmac00/launchpad:pass-artifactory-credentials into launchpad:master

 

I think we have not discussed about a design decision whether the credentials are passed always or not - I went with "always" as then there is no need to introspect the .launchpad.yaml file.

I'd like to understand better how this is really a safe thing to do - ie the credentials are safe from user code executed on a builder. Maybe we can speak about that during standup.
-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/420028
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:pass-artifactory-credentials into launchpad:master.



References