launchpad-reviewers team mailing list archive

[Colin Watson <mp+421685@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/doc/how-to/running.rst b/doc/how-to/running.rst
> index 39edf9a..5921eac 100644
> --- a/doc/how-to/running.rst
> +++ b/doc/how-to/running.rst
> @@ -61,6 +61,13 @@ This assumes you already have LXD set up.  If not, follow the `instructions
>  <https://linuxcontainers.org/lxd/getting-started-cli/>`_ for getting it
>  installed and configured on your network.
>  
> +.. note::
> +
> +    If you want to run a second Launchpad instance, e.g. to test compatibility

A much better approach is to run multiple containers.  There's no need for separate home directories - I use multiple containers all the time without the need for this, so I would not like to see this unnecessary complication entrenched in our documentation.

> +    with the next Ubuntu LTS version, please use a profile with a different
> +    ``$HOME`` directory, as both ``rocketfuel-setup`` and ``rocketfuel-get``
> +    build the instance directory from ``~/rocketfuel-env.sh``.
> +
>  1. If you haven't done so already, run this script to set up LXD to let you
>     use your home directory inside the container.  Some developers prefer to
>     only mount a subdirectory of their home directory in the container: to do


-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/421685
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:add-note-about-running-two-instances into launchpad:master.