launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+422126@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lpcraft/commands/tests/test_run.py b/lpcraft/commands/tests/test_run.py
> index df96d69..f52a84b 100644
> --- a/lpcraft/commands/tests/test_run.py
> +++ b/lpcraft/commands/tests/test_run.py
> @@ -1584,8 +1591,8 @@ class TestRun(RunBaseTestCase):
>          self.assertEqual(
>              [
>                  call(
> -                    ["apt", "install", "-y", "unknown_package"],
> -                    cwd=Path("/root/lpcraft/project"),
> +                    ["apt", "update"],
> +                    cwd=PosixPath("/root/lpcraft/project"),

I do not like this change a lot, as this suggests the run breaks when updating the package sources. I find no way to make exactly the second command, ie the installation failing. I think this is a limitation of our test system. I would either remove this assertion or add a comment. Will do after standup.

>                      env={},
>                      stdout=ANY,
>                      stderr=ANY,


-- 
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/422126
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/lpcraft:always-update-repositories into lpcraft:main.