← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~cjwatson/launchpad:black-answers-browser into launchpad:master

 

As this was clearly marked as RFC, I would really prefer single line import statements.

So instead of ....

```
-    )
-from lp.app.browser.launchpadform import (
-    action,
-    LaunchpadFormView,
-    safe_action,
-    )
+)
+from lp.app.browser.launchpadform import LaunchpadFormView, action, safe_action
```

I favor

```
from lp.app.browser.launchpadform import LaunchpadFormView
from lp.app.browser.launchpadform import action
from lp.app.browser.launchpadform import safe_action
```

- still two lines shorter than the previous style
- very easy and quickly to scan with my eyes
- minimal and clear diff on changes
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/423202
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:black-answers-browser into launchpad:master.



References