launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+423380@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/code/model/tests/test_cibuildbehaviour.py b/lib/lp/code/model/tests/test_cibuildbehaviour.py
> index 17b78e9..bd0f397 100644
> --- a/lib/lp/code/model/tests/test_cibuildbehaviour.py
> +++ b/lib/lp/code/model/tests/test_cibuildbehaviour.py
> @@ -320,10 +320,10 @@ class TestAsyncCIBuildBehaviour(StatsMixin, TestCIBuildBehaviourBase):
>          self.pushConfig(
>              "cibuild.soss",
>              environment_variables=json.dumps({
> -                "PIP_INDEX_URL": "http://%(read_auth)s@%(base_url)s/simple",
> +                "PIP_INDEX_URL": "https://%(read_auth)s@xxxxxxxxxxxxxxxxxxxxx/artifactory/soss-python-stable/simple/",  # noqa: E501

I used examples which are very close to the real ones in order to avoid confusion about how those URLs look. Though I used the example domain so that accidental actions with out production host can be a avoided.

>                  "SOME_PATH": "/bin/zip"}),
>              apt_repositories=json.dumps([
> -                "deb https://%(read_auth)s@%(base_url)s/repository focal main",
> +                "deb https://%(read_auth)s@xxxxxxxxxxxxxxxxxxxxx/artifactory/soss-deb-stable focal main universe",  # noqa: E501
>                  "deb https://public_ppa.example.net/repository focal main"])
>          )
>          package = self.factory.makeDistributionSourcePackage(


-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/423380
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:base_url_has_a_scheme into launchpad:master.