launchpad-reviewers team mailing list archive

[Guruprasad <mp+424302@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master.

Commit message:
Display a scrollbar when the diff text is too long

Also expand the containing table to fit the long lines.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/424302
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master.

diff --git a/lib/canonical/launchpad/icing/style.css b/lib/canonical/launchpad/icing/style.css
index 92f2d6f..1be36de 100644
--- a/lib/canonical/launchpad/icing/style.css
+++ b/lib/canonical/launchpad/icing/style.css
@@ -623,6 +623,7 @@ table.code th, table.code td {
 .codereviewcomment .attachment, #review-diff .attachment,
 div.diff .attachmentBody {
   background-color: #f6f6f6;
+  overflow: scroll;
 }
 div.diff .horizontal {
   margin: 0;
@@ -636,7 +637,7 @@ table.diff {
    margin-bottom: 0.5em;
 }
 table.unidiff {
-   table-layout: fixed;
+   table-layout: auto;
 }
 
 table.diff .nav-cursor:before {