launchpad-reviewers team mailing list archive

[Colin Watson <mp+425052@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~cjwatson/launchpad:doctest-rst into launchpad:master has been updated.

Description changed to:

We shouldn't have as many doctests as we do, but as long as we do, let's make them a little easier to work with.  Naming these files `*.rst` rather than `*.txt` makes various tools work better (for example, vim uses appropriate highlighting for them automatically, and some refactoring tools recognize them as doctests), and it makes it easier to treat them separately from things like text files used as test data.

I considered breaking this up to be a bit smaller, but there's no value in deploying this to production one step at a time since it's all tests, and it was much easier to just do the whole thing in bulk.  This is just about all straightforward substitution, with a few bits of opportunistically fixing up stale references to various doctest file names; the only non-obvious thing here is in `lib/lp/tests/test_opensource.py`, where we should change `.txt` to `.rst` but can't yet until we fix launchpadlib's doctests.

Launchpad's merge diff algorithm apparently doesn't notice all of the renames, so if you want to review the whole patch it's best to pull the branch and use git locally.  The actual diffstat says "1069 files changed, 536 insertions(+), 533 deletions(-)".

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/425052
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:doctest-rst into launchpad:master.