launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~cjwatson/launchpad:db-narrow-bpr-ci-build-unique-index into launchpad:master

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Colin Watson <mp+425220@xxxxxxxxxxxxxxxxxx>
Date: Thu, 23 Jun 2022 08:57:06 -0000
In-reply-to: <165589699283.26126.2345949661540454353.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+425220@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

cjwatson: Ah, I'd forgotten that DROP INDEX CONCURRENTLY exists.  I'll just merge that into db-narrow-bpr-ci-build-unique-index then
cjwatson: Do you think I should do something like CASE WHEN binarypackageformat IN (1, 2, 5) THEN 1 ELSE binarypackageformat END?  I hadn't been going to bother since CI builds are mostly being used for other package types than debs
wgrant: (it's REINDEX CONCURRENTLY that we don't have until pg12, indeed)
wgrant: I'm not too fussed on whether you do that CASE or not. So probably not, for simplicity.
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/425220
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:db-narrow-bpr-ci-build-unique-index into launchpad:master.