launchpad-reviewers team mailing list archive

[Guruprasad <mp+425367@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/requirements/launchpad.txt b/requirements/launchpad.txt
> index e66e855..a9923c6 100644
> --- a/requirements/launchpad.txt
> +++ b/requirements/launchpad.txt
> @@ -40,7 +40,9 @@ defusedxml==0.6.0
>  distro==1.4.0
>  dkimpy==1.0.4
>  dnspython==1.16.0
> -dohq-artifactory==0.7.630
> +# https://code.launchpad.net/~launchpad/dohq-artifactory/+git/dohq-artifactory/+ref/0.7.630
> +# lp1 Fix the version determination code in setup.py to allow installing the wheel.

Afaik, we are able to build the wheel but unable to install it because of the version mismatch issue. Not sure what you meant by "building fails". Can you elaborate?

> +dohq-artifactory==0.7.630+lp1
>  dulwich==0.19.16
>  eggtestinfo==0.3
>  enum34==1.1.6


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/425367
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:update-dohq-artifactory-requirement into launchpad:master.