launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~lgp171188/launchpad:split-security.py-services into launchpad:master

To: Guruprasad <guruprasad.ln@xxxxxxxxxxxxx>
From: Guruprasad <mp+426635@xxxxxxxxxxxxxxxxxx>
Date: Mon, 11 Jul 2022 13:43:42 -0000
In-reply-to: <165754682031.2570.6487616801578892589.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+426635@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I did not move the security adapter for `lp.services.webapp.interfaceslp.services.webapp.interfaces.ILaunchpadRoot`, `EditByRegistryExpertsOrAdmins`, because it is used by some security adapters still in `lib/lp/security.py` (to be split soon) and moving it now will cause circular imports. I will fix this once the sub-classes are all moved out to their respective packages.
-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/426635
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:split-security.py-services into launchpad:master.

References

[Merge] ~lgp171188/launchpad:split-security.py-services into launchpad:master
From: Guruprasad, 2022-07-11