launchpad-reviewers team mailing list archive

[Guruprasad <mp+427259@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/registry/personmerge.py b/lib/lp/registry/personmerge.py
> index 2cef92b..9a2729d 100644
> --- a/lib/lp/registry/personmerge.py
> +++ b/lib/lp/registry/personmerge.py
> @@ -980,6 +998,9 @@ def merge_people(from_person, to_person, reviewer, delete=False):
>      _mergeCharmRecipe(cur, from_id, to_id)
>      skip.append(('charmrecipe', 'owner'))
>  
> +    _mergeVulnerabilitySubscription(cur, from_id, to_id)

I already had these changes in my vulnerability subscription model changes branch since I had adapted the similar changes made for oci recipe subscription. But it looks like these are required with the db patch.

> +    skip.append(('vulnerabilitysubscription', 'person'))
> +
>      # Sanity check. If we have a reference that participates in a
>      # UNIQUE index, it must have already been handled by this point.
>      # We can tell this by looking at the skip list.


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/427259
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:fix-vulnerabilitysubscription-person-unique-index into launchpad:db-devel.