launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+427516@xxxxxxxxxxxxxxxxxx>]

I do prefer to use tox for installing and running pre-commit for the reasons we discussed during today's retro - installing packages via apt adds some more complexity.

Diff comments:

> diff --git a/.launchpad.yaml b/.launchpad.yaml
> new file mode 100644
> index 0000000..d2bcceb
> --- /dev/null
> +++ b/.launchpad.yaml
> @@ -0,0 +1,19 @@
> +pipeline:
> +  - docs
> +  - lint
> +
> +jobs:
> +  docs:
> +    architectures: amd64
> +    packages:
> +      - tox
> +    run: "tox -e docs"
> +    series: jammy
> +  lint:
> +    architectures: amd64
> +    packages:
> +      - tox
> +      - git
> +      - golang
> +    run: "tox -e lint"
> +    series: jammy

The tox plugin for lpcraft is currently not yet suited to run single envs, and I did not want to create a `build_docs_and_run_linters` job. I think it would make sense to improve the tox plugin, but before doing that I wanted to wait for a real need, e.g. by our main users of lpcraft.



-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/427516
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:run-pre-commit-in-ci into launchpad:master.