launchpad-reviewers team mailing list archive

Thread
Date

[Merge] ~andrey-fedoseev/launchpad:selenium into launchpad:master

To: mp+427612@xxxxxxxxxxxxxxxxxx
From: Andrey Fedoseev <mp+427612@xxxxxxxxxxxxxxxxxx>
Date: Fri, 29 Jul 2022 11:06:16 -0000
Reply-to: mp+427612@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Andrey Fedoseev has proposed merging ~andrey-fedoseev/launchpad:selenium into launchpad:master.

Commit message:
Increase the timeout value in html5browser test

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/427612

Hopefully, this will prevent test flakiness in the build environment
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:selenium into launchpad:master.

diff --git a/lib/lp/testing/tests/test_html5browser.py b/lib/lp/testing/tests/test_html5browser.py
index 5118843..bdc6229 100644
--- a/lib/lp/testing/tests/test_html5browser.py
+++ b/lib/lp/testing/tests/test_html5browser.py
@@ -40,9 +40,9 @@ class TestBrowser(TestCase):
                                 results: {"spam": "ham"},
                                 type: "complete"
                             });
-                        }, 200);
-                    }, 200);
-                }, 100);
+                        }, 2000);
+                    }, 2000);
+                }, 1000);
             };
             </script>
             </head><body></body></html>
@@ -55,7 +55,7 @@ class TestBrowser(TestCase):
         self.addCleanup(self.browser.close)
 
     def test_load_test_results(self):
-        results = self.browser.run_tests(self.file_uri, timeout=1000)
+        results = self.browser.run_tests(self.file_uri, timeout=10000)
         self.assertEqual(results.status, results.Status.SUCCESS)
         self.assertEqual(
             results.results,
@@ -66,7 +66,7 @@ class TestBrowser(TestCase):
         )
 
     def test_timeout_error(self):
-        results = self.browser.run_tests(self.file_uri, timeout=150)
+        results = self.browser.run_tests(self.file_uri, timeout=1500)
         self.assertEqual(results.status, results.Status.TIMEOUT)
         self.assertIsNone(results.results)
         self.assertEqual(
@@ -76,7 +76,7 @@ class TestBrowser(TestCase):
 
     def test_incremental_timeout_success(self):
         results = self.browser.run_tests(
-            self.file_uri, timeout=1000, incremental_timeout=300
+            self.file_uri, timeout=10000, incremental_timeout=3000
         )
         self.assertEqual(results.status, results.Status.SUCCESS)
         self.assertEqual(
@@ -89,7 +89,7 @@ class TestBrowser(TestCase):
 
     def test_incremental_timeout_error(self):
         results = self.browser.run_tests(
-            self.file_uri, timeout=1000, incremental_timeout=150
+            self.file_uri, timeout=10000, incremental_timeout=1500
         )
         self.assertEqual(results.status, results.Status.TIMEOUT)
         self.assertIsNone(results.results)