launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~jugmac00/launchpad-buildd:provide-additional-repositories-instead-of-replacing-them into launchpad-buildd:master

To: mp+428410@xxxxxxxxxxxxxxxxxx
From: Dan Ryan <mp+428410@xxxxxxxxxxxxxxxxxx>
Date: Tue, 16 Aug 2022 17:41:43 -0000
In-reply-to: <166066837422.19377.17926785335176390583.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+428410@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

this change makes sense to me -- I don't see any immediate concerns as this is largely a variable/argument name change as long as the other pieces are merged with it
-- 
https://code.launchpad.net/~jugmac00/launchpad-buildd/+git/launchpad-buildd/+merge/428410
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad-buildd:provide-additional-repositories-instead-of-replacing-them into launchpad-buildd:master.

References

[Merge] ~jugmac00/launchpad-buildd:provide-additional-repositories-instead-of-replacing-them into launchpad-buildd:master
From: Jürgen Gmach, 2022-08-16