launchpad-reviewers team mailing list archive

[Haw Loeung <mp+428577@xxxxxxxxxxxxxxxxxx>]

Haw Loeung has proposed merging lp:~hloeung/canonical-mojo-specs/launchpad-fix-squid-warnings-reduce-cron-spam into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

Commit message:
Fix squid parse/check warnings to reduce cron spam

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~hloeung/canonical-mojo-specs/launchpad-fix-squid-warnings-reduce-cron-spam/+merge/428577
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~hloeung/canonical-mojo-specs/launchpad-fix-squid-warnings-reduce-cron-spam into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

=== modified file 'lp/mojo-lp-snap-proxy/devel/deploy'
--- lp/mojo-lp-snap-proxy/devel/deploy	2021-05-06 10:51:02 +0000
+++ lp/mojo-lp-snap-proxy/devel/deploy	2022-08-18 22:54:41 +0000
@@ -25,7 +25,7 @@
                 auth_list: |
                     [
                     {port: [80], method: [GET],
-                     src: [127.0.0.1/8],
+                     src: [127.0.0.0/8],
                      dst: [
                        # blog.launchpad.net, a benign host for nagios checks.
                        91.189.88.184, 91.189.88.185,

=== modified file 'lp/mojo-lp-snap-proxy/production/deploy'
--- lp/mojo-lp-snap-proxy/production/deploy	2021-04-29 20:43:03 +0000
+++ lp/mojo-lp-snap-proxy/production/deploy	2022-08-18 22:54:41 +0000
@@ -42,7 +42,7 @@
                      # the PTR and match it against dstdomain rules!
                      # This is obviously completely holey.
                      {port: [80], method: [GET],
-                      src: [127.0.0.1/8],
+                      src: [127.0.0.0/8],
                       # DSTDOMAIN IS FORBIDDEN.
                       dst: [
                         # blog.launchpad.net, a benign host for nagios checks.
@@ -166,7 +166,7 @@
                      # time.
                      {port: [80, 443, 9418],
                       method: [GET, POST, CONNECT, OPTIONS, PROPFIND, REPORT],
-                      dst: [0.0.0.0/1, 128.0.0.1/1, "2000::/3"],
+                      dst: [0.0.0.0/1, 128.0.0.0/1, "2000::/3"],
                       http_access: allow},
                      # Deny anything with any IP address that has not
                      # matched already.

=== modified file 'lp/mojo-lp-snap-proxy/qastaging/deploy'
--- lp/mojo-lp-snap-proxy/qastaging/deploy	2020-12-07 17:01:00 +0000
+++ lp/mojo-lp-snap-proxy/qastaging/deploy	2022-08-18 22:54:41 +0000
@@ -42,7 +42,7 @@
                      # the PTR and match it against dstdomain rules!
                      # This is obviously completely holey.
                      {port: [80], method: [GET],
-                      src: [127.0.0.1/8],
+                      src: [127.0.0.0/8],
                       # DSTDOMAIN IS FORBIDDEN.
                       dst: [
                         # blog.launchpad.net, a benign host for nagios checks.
@@ -168,7 +168,7 @@
                      # time.
                      {port: [80, 443, 9418],
                       method: [GET, POST, CONNECT, OPTIONS, PROPFIND, REPORT],
-                      dst: [0.0.0.0/1, 128.0.0.1/1, "2000::/3"],
+                      dst: [0.0.0.0/1, 128.0.0.0/1, "2000::/3"],
                       http_access: allow},
                      # Deny anything with any IP address that has not
                      # matched already.

=== modified file 'lp/mojo-lp-webhooks-proxy/devel/deploy'
--- lp/mojo-lp-webhooks-proxy/devel/deploy	2017-03-28 14:21:58 +0000
+++ lp/mojo-lp-webhooks-proxy/devel/deploy	2022-08-18 22:54:41 +0000
@@ -54,7 +54,7 @@
                      # ::/3 before whitelisting IPv4 you will have a bad
                      # time.
                      {port: [80, 443], method: [GET, POST, CONNECT],
-                      dst: [0.0.0.0/1, 128.0.0.1/1, "2000::/3"],
+                      dst: [0.0.0.0/1, 128.0.0.0/1, "2000::/3"],
                       http_access: allow},
                      # Deny anything with any IP address that has not
                      # matched already.

=== modified file 'lp/mojo-lp-webhooks-proxy/production/deploy'
--- lp/mojo-lp-webhooks-proxy/production/deploy	2021-05-06 10:51:02 +0000
+++ lp/mojo-lp-webhooks-proxy/production/deploy	2022-08-18 22:54:41 +0000
@@ -63,7 +63,7 @@
                      # ::/3 before whitelisting IPv4 you will have a bad
                      # time.
                      {port: [80, 443], method: [GET, POST, CONNECT],
-                      dst: [0.0.0.0/1, 128.0.0.1/1, "2000::/3"],
+                      dst: [0.0.0.0/1, 128.0.0.0/1, "2000::/3"],
                       http_access: allow},
                      # Deny anything with any IP address that has not
                      # matched already.

=== modified file 'lp/mojo-lp-webhooks-proxy/qastaging/deploy'
--- lp/mojo-lp-webhooks-proxy/qastaging/deploy	2021-05-06 10:51:02 +0000
+++ lp/mojo-lp-webhooks-proxy/qastaging/deploy	2022-08-18 22:54:41 +0000
@@ -63,7 +63,7 @@
                      # ::/3 before whitelisting IPv4 you will have a bad
                      # time.
                      {port: [80, 443], method: [GET, POST, CONNECT],
-                      dst: [0.0.0.0/1, 128.0.0.1/1, "2000::/3"],
+                      dst: [0.0.0.0/1, 128.0.0.0/1, "2000::/3"],
                       http_access: allow},
                      # Deny anything with any IP address that has not
                      # matched already.