launchpad-reviewers team mailing list archive

[Colin Watson <mp+428856@xxxxxxxxxxxxxxxxxx>]

Review: Approve

The `libgpgme11-dev` story is actually a little more complicated than that.  We _didn't_ forward-port the xenial package to bionic.  Instead, in bionic, the official `libgpgme-dev` package has this metadata:

  Provides: libgpgme11-dev (= 1.10.0-1ubuntu1)

That means that a dependency on `libgpgme11-dev` still works.  And in fact, there's similar metadata in focal and even jammy, so the `libgpgme-dev` change is technically unnecessary.  I think you only needed this because (I'm guessing) you've been installing individual packages by hand using `apt install` rather than being able to install the whole of `launchpad-dependencies` at once, due to the `python-convoy` situation.

However, I'm OK with this change anyway to make things easier for people installing individual dependencies by hand, as well as because once we require bionic or later we can simplify this dependency to just `libgpgme-dev` without the alternative.

Diff comments:

> 
> === modified file 'debian/control'
> --- debian/control	2022-08-18 14:29:09 +0000
> +++ debian/control	2022-08-24 13:23:29 +0000
> @@ -86,6 +86,19 @@
>   This metapackage depends on all of the packages necessary to run a Launchpad
>   database.
>  
> +Package: launchpad-database-dependencies-12
> +Architecture: all
> +Depends: postgresql-12,
> +  postgresql-plpython-12,

Can you drop this line, please?  We no longer use PL/Python 2 (favouring PL/Python 3 instead), and `postgresql-plpython-12` doesn't exist on focal.

> +  postgresql-plpython3-12,
> +  postgresql-client-12,
> +  postgresql-12-slony1-2,
> +  postgresql-12-debversion,
> +  ${misc:Depends}
> +Description: Metapackage for Launchpad database packages
> + This metapackage depends on all of the packages necessary to run a Launchpad
> + database.
> +
>  Package: launchpad-messagequeue-dependencies
>  Architecture: all
>  Depends: rabbitmq-server, stunnel4, ${misc:Depends}


-- 
https://code.launchpad.net/~lgp171188/meta-lp-deps/focal-fixes/+merge/428856
Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps.