launchpad-reviewers team mailing list archive

[Colin Watson <mp+428914@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:no-default-db into launchpad:master.

Commit message:
Unset default database connection strings

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/428914

It doesn't make sense to set production database connection strings in the configuration schema.  Production deployments already override these connection strings to something else in any case, and nothing else will be able to connect to the production databases.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:no-default-db into launchpad:master.

diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
index 3d2386c..ad45db9 100644
--- a/lib/lp/services/config/schema-lazr.conf
+++ b/lib/lp/services/config/schema-lazr.conf
@@ -587,9 +587,9 @@ timeout: 30
 # Note that user is not included, as it is specified by the dbuser
 # option. This allows config sections to easily override just the dbuser.
 # datatype: pgconnection
-rw_main_primary: dbname=launchpad_prod_3 host=wildcherry.canonical.com
+rw_main_primary: none
 # datatype: pgconnection
-rw_main_standby: dbname=launchpad_prod_2 host=chokecherry.canonical.com
+rw_main_standby: none
 
 # If the replication lag is more than this many seconds, standby databases
 # will not be used.