launchpad-reviewers team mailing list archive

[Colin Watson <mp+429004@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/remove-subunit into lp:meta-lp-deps.

Commit message:
Remove Recommends on subunit.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/meta-lp-deps/remove-subunit/+merge/429004

zope.testrunner uses this from Launchpad's virtualenv, while buildbot workers use subunit-2to1 either from the system package on the worker host (currently) or the virtualenv (soon).  In neither case is a Recommends from launchpad-developer-dependencies useful.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/meta-lp-deps/remove-subunit into lp:meta-lp-deps.

=== modified file 'debian/changelog'
--- debian/changelog	2022-08-25 11:54:30 +0000
+++ debian/changelog	2022-08-26 15:31:15 +0000
@@ -10,6 +10,9 @@
   * Remove Recommends on pyflakes; we use pre-commit for lint checking
     nowadays.
   * Remove dependency on bzr.
+  * Remove Recommends on subunit; zope.testrunner uses this from Launchpad's
+    virtualenv, while buildbot workers use subunit-2to1 either from the
+    system package on the worker host (currently) or the virtualenv (soon).
 
   [ Andrey Fedoseev ]
   * Add firefox-geckodriver to launchpad-developer-dependencies;

=== modified file 'debian/control'
--- debian/control	2022-08-25 11:54:30 +0000
+++ debian/control	2022-08-26 15:31:15 +0000
@@ -58,7 +58,6 @@
   fakeroot, rsync, memcached,
   xvfb, firefox, firefox-geckodriver, intltool,
   ${misc:Depends}
-Recommends: subunit
 Suggests: apache2, libapache2-mod-wsgi
 Description: Metapackage for development dependencies of Launchpad
  This metapackage depends on all of the packages required to do development