launchpad-reviewers team mailing list archive

[Colin Watson <mp+429574@xxxxxxxxxxxxxxxxxx>]

Could you add a debian/changelog entry for this?

Diff comments:

> diff --git a/lpbuildd/tests/test_binarypackage.py b/lpbuildd/tests/test_binarypackage.py
> index 9e3e155..71982d4 100644
> --- a/lpbuildd/tests/test_binarypackage.py
> +++ b/lpbuildd/tests/test_binarypackage.py
> @@ -418,6 +418,7 @@ class TestBinaryPackageBuildManagerIteration(TestCase):
>              dedent("""\
>                  Package: foo
>                  Build-Depends: debhelper (>= 9~), bar | baz
> +                Build-Depends-Arch: qux

Could you update the comment at the top of this method to match?  I.e.:

    def test_getBuildDepends_arch_dep(self):
        # getBuildDepends returns both Build-Depends and Build-Depends-Arch for
        # architecture-dependent builds.

Also, the comment at the top of the next method should probably change as well:

    def test_getBuildDepends_arch_indep(self):
        # getBuildDepends returns all of Build-Depends, Build-Depends-Arch,
        # and Build-Depends-Indep for architecture-independent builds.

... and it might be worth adding Build-Depends-Arch to the test data in `test_getBuildDepends_arch_indep` as well, since we do in fact want to include it for arch-indep builds as well (since launchpad-buildd has a mode that builds both arch-indep and arch-dep, but doesn't have a Debian-style "arch-indep-only" mode).

>                  Build-Depends-Indep: texlive-base
>                  """))
>          self.assertThat(


-- 
https://code.launchpad.net/~apw/launchpad-buildd/+git/my/+merge/429574
Your team Launchpad code reviewers is requested to review the proposed merge of ~apw/launchpad-buildd/+git/my:handle-build-depends-arch into launchpad-buildd:master.