launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #29153
Re: [Merge] ~lgp171188/launchpad:focal-fixes into launchpad:master
Diff comments:
> diff --git a/lib/lp/archiveuploader/tests/nascentuploadfile.rst b/lib/lp/archiveuploader/tests/nascentuploadfile.rst
> index 24b3011..8c75f65 100644
> --- a/lib/lp/archiveuploader/tests/nascentuploadfile.rst
> +++ b/lib/lp/archiveuploader/tests/nascentuploadfile.rst
> @@ -487,7 +487,7 @@ changes file:
> >>> list(ed_binary_deb.verify())
> [UploadError(...'ed_0.2-20_i386.deb
> control file lists section as main/editors but changes file has
> - main/net.',)]
> + main/net.'...)]
I wanted to use something like the regex `(,)?` instead of `...`, which can match more than what we want here. But I couldn't find out how to do it here.
>
> It also checks the priority against the changes file:
>
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/429616
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:focal-fixes into launchpad:master.
References