launchpad-reviewers team mailing list archive

[Guruprasad <mp+430357@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/templates/vulnerability-listing-detailed.pt b/lib/lp/bugs/templates/vulnerability-listing-detailed.pt
> new file mode 100644
> index 0000000..315587f
> --- /dev/null
> +++ b/lib/lp/bugs/templates/vulnerability-listing-detailed.pt
> @@ -0,0 +1,23 @@
> +<tal:root
> +  xmlns:tal="http://xml.zope.org/namespaces/tal";
> +  xmlns:metal="http://xml.zope.org/namespaces/metal";
> +  omit-tag="">
> +  <div tal:attributes="id string:vulnerability-${context/id}">
> +    <img src="/@@/cve" />
> +    <a tal:attributes="href context/fmt:url"
> +       tal:content="context/title"></a>
> +    <div style="margin-left: 25px"
> +        tal:condition="context/description"
> +        tal:content="context/description">
> +    </div>
> +    <div style="margin-left: 25px"
> +        tal:condition="python: not context.description and context.cve"

This issues n+1 queries to fetch the related CVE and needs to be fixed by preloading with a decorated result set.

> +        tal:content="context/cve/description">
> +    </div>
> +    <div style="margin-left: 25px"
> +        tal:condition="python: not context.description and not context.cve"
> +        tal:content="context/description">
> +    </div>
> +  </div>
> +  <hr />
> +</tal:root>


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/430357
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:vulnerability-set-view into launchpad:master.