launchpad-reviewers team mailing list archive

[Colin Watson <mp+431123@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:bump-keyserver-test-timeout into launchpad:master.

Commit message:
Bump keyserver TestWebResources timeout to 30 seconds

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/431123

The previous timeout of 2 seconds was not very robust in practice: scheduling blips in parallel test runs could easily cause tests to exceed that.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:bump-keyserver-test-timeout into launchpad:master.

diff --git a/lib/lp/testing/keyserver/tests/test_web.py b/lib/lp/testing/keyserver/tests/test_web.py
index c493f01..9a24613 100644
--- a/lib/lp/testing/keyserver/tests/test_web.py
+++ b/lib/lp/testing/keyserver/tests/test_web.py
@@ -27,7 +27,7 @@ class RegularCallbackExecuted(Exception):
 
 class TestWebResources(TestCase):
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=2)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=30)
 
     def setUpKeysDirectory(self):
         path = self.makeTemporaryDirectory()