launchpad-reviewers team mailing list archive

[Andrey Fedoseev <mp+430983@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~andrey-fedoseev/launchpad:bug-attachment-url into launchpad:master has been updated.

Description changed to:

`libraryfile` field of `BugAttachment` is not optional, an attachment can either contain a file, or have a URL

Add `displayed_url` property to `BugAttachment` that contains either a proxied attachment file URL, or the URL associated with the attachment.


Improve the `BugAttachment` links:

- Use the formatter API to create the links
- Use different icons depending on the link type: external URL, a patch, a downloadable file
- Add rel=nofollow to external URLs

For more details, see:
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/430983
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:bug-attachment-url into launchpad:master.