launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+431673@xxxxxxxxxxxxxxxxxx>]

I think this is the first time I have encountered a three-state-boolean / troolean? :-), at least in Python.

It took me a while to come to a conclusion whether this is clever or awkward and at the end, I think its both :-)

The issue is... it is impossible to know the three states with a high certainty without looking the param up.

This leaves two possible solutions:
- two booleans a la `include_condemned_files` and `include_non_condemned_files`
- enum a la `file_status`: `only_condemned_files`, `only_non_condemned_files`, `all_files`

I think I like the enum much better.

I am sure you can come up with a better naming.
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/431673
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:archive-translate-path-non-pool-multiple into launchpad:master.