← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~cjwatson/launchpad:archive-translate-path-non-pool-multiple into launchpad:master

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Colin Watson <mp+431673@xxxxxxxxxxxxxxxxxx>
Date: Mon, 17 Oct 2022 17:46:13 -0000
In-reply-to: <166602127547.25567.8400225149861344595.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+431673@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I definitely don't like the two-contradictory-booleans approach.

I'm not especially keen on the enum either, but I guess I can look at that (tomorrow).
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/431673
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:archive-translate-path-non-pool-multiple into launchpad:master.

References

[Merge] ~cjwatson/launchpad:archive-translate-path-non-pool-multiple into launchpad:master
From: Colin Watson, 2022-10-17