launchpad-reviewers team mailing list archive

[Colin Watson <mp+433384@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:remove-cookie-domains into launchpad:master.

Commit message:
Remove config.launchpad.cookie_domains

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433384

This was deprecated in https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/431520.  Following https://code.launchpad.net/~cjwatson/lp-production-configs/remove-cookie-domains/+merge/431749, it's no longer used anywhere.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:remove-cookie-domains into launchpad:master.

diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
index ca906a6..d832788 100644
--- a/lib/lp/services/config/schema-lazr.conf
+++ b/lib/lp/services/config/schema-lazr.conf
@@ -989,14 +989,6 @@ http_proxy: none
 # datatype: string
 ca_certificates_path: none
 
-# Session cookies being sent to a subdomain of the parent
-# domains listed here will be sent to the parent domain,
-# allowing sessions to be shared between vhosts.
-# Domains should not start with a leading '.'.
-# Deprecated; Launchpad now only considers vhost.mainsite.hostname.
-cookie_domains:
-    demo.launchpad.net, staging.launchpad.net, launchpad.net, launchpad.test
-
 # Maximum size of product release download files in bytes. A value
 # of 0 means no limit.
 # datatype: integer