launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~lgp171188/lpcraft:import-ppa-signing-keys into lpcraft:main

To: Guruprasad <guruprasad.ln@xxxxxxxxxxxxx>
From: Guruprasad <mp+433733@xxxxxxxxxxxxxxxxxx>
Date: Tue, 29 Nov 2022 04:53:00 -0000
Reply-to: mp+433733@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx


Diff comments:

> diff --git a/NEWS.rst b/NEWS.rst
> index a63549c..97dd9d9 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -7,7 +7,10 @@ Version history
>  
>  - Sanitize the project name before cleaning.
>  
> -- Allow specifying PPAs using the shortform notation.
> +- Allow specifying PPAs using the short-form notation.
> +
> +- Automatically import the signing keys for PPAs specified using

Should we forbid the user from specifying the `trusted` parameter when specifying PPAs using the short-form notation? I think it makes sense to since we are automatically importing the PPA's signing key.

> +  the short-form notation.
>  
>  0.0.35 (2022-10-27)
>  ===================


-- 
https://code.launchpad.net/~lgp171188/lpcraft/+git/lpcraft/+merge/433733
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/lpcraft:import-ppa-signing-keys into lpcraft:main.