launchpad-reviewers team mailing list archive

[Colin Watson <mp+435693@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:fix-soss-source-url-deb into launchpad:master.

Commit message:
Fix test failures due to soss.source_url for Debian binaries

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1999821 in Launchpad itself: "soss.source_url is missing for published deb files"
  https://bugs.launchpad.net/launchpad/+bug/1999821

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/435693

Regression caused by commit 1d16aba7f2c87b5074f888d8f001d72ad511bd15.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-soss-source-url-deb into launchpad:master.

diff --git a/lib/lp/archivepublisher/tests/test_publisher.py b/lib/lp/archivepublisher/tests/test_publisher.py
index c675a51..f3ac846 100644
--- a/lib/lp/archivepublisher/tests/test_publisher.py
+++ b/lib/lp/archivepublisher/tests/test_publisher.py
@@ -4260,6 +4260,10 @@ class TestArtifactoryPublishing(TestPublisherBase):
                 "launchpad.source-name": ["hello"],
                 "launchpad.source-version": ["1.0"],
                 "soss.license": ["/usr/share/doc/hello/copyright"],
+                "soss.source_url": [
+                    "%s/%s/pool/h/hello/hello_1.0.dsc"
+                    % (self.base_url, self.archive.name)
+                ],
                 "soss.type": ["binary"],
             },
             binary_path.properties,
@@ -4369,6 +4373,10 @@ class TestArtifactoryPublishing(TestPublisherBase):
                 "launchpad.source-name": ["hello"],
                 "launchpad.source-version": ["1.0"],
                 "soss.license": ["/usr/share/doc/hello/copyright"],
+                "soss.source_url": [
+                    "%s/%s/pool/h/hello/hello_1.0.dsc"
+                    % (self.base_url, self.archive.name)
+                ],
                 "soss.type": ["binary"],
             },
             binary_path.properties,
@@ -4517,6 +4525,10 @@ class TestArtifactoryPublishing(TestPublisherBase):
                 "launchpad.source-name": ["hello"],
                 "launchpad.source-version": ["1.0"],
                 "soss.license": ["/usr/share/doc/hello/copyright"],
+                "soss.source_url": [
+                    "%s/%s/pool/h/hello/hello_1.0.dsc"
+                    % (self.base_url, self.archive.name)
+                ],
                 "soss.type": ["binary"],
             },
             binary_path.properties,