launchpad-reviewers team mailing list archive

[Guruprasad <mp+437888@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:use-set-comprehension-to-construct-a-list into launchpad:master.

Commit message:
Use set comprehension to construct a set

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/437888
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:use-set-comprehension-to-construct-a-list into launchpad:master.

diff --git a/lib/lp/registry/browser/distribution.py b/lib/lp/registry/browser/distribution.py
index 7f56792..e5b514a 100644
--- a/lib/lp/registry/browser/distribution.py
+++ b/lib/lp/registry/browser/distribution.py
@@ -737,14 +737,13 @@ class DistributionPackageSearchView(PackageSearchViewBase):
         for package_cache in self.exact_matches:
             package = package_cache.distributionsourcepackage
 
-            # In the absense of Python3.0's set comprehension, we
-            # create a list, convert the list to a set and back again:
-            distroseries_list = [
-                pubrec.distroseries.name
-                for pubrec in package.current_publishing_records
-                if pubrec.distroseries.active
-            ]
-            distroseries_list = list(set(distroseries_list))
+            distroseries_list = list(
+                {
+                    pubrec.distroseries.name
+                    for pubrec in package.current_publishing_records
+                    if pubrec.distroseries.active
+                }
+            )
 
             # Yay for alphabetical series names.
             distroseries_list.sort()