launchpad-reviewers team mailing list archive

[Guruprasad <mp+438674@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/registry/browser/announcement.py b/lib/lp/registry/browser/announcement.py
> index 7ef6105..870e36c 100644
> --- a/lib/lp/registry/browser/announcement.py
> +++ b/lib/lp/registry/browser/announcement.py
> @@ -41,6 +42,13 @@ from lp.services.webapp.menu import (
>  from lp.services.webapp.publisher import LaunchpadView, canonical_url
>  
>  
> +def current_user_can_announce(pillar):
> +    """Can the current user make announcements for the pillar?"""
> +    return check_permission("launchpad.Edit", pillar) and check_permission(
> +        "launchpad.AnyLegitimatePerson", pillar

Should we exempt admins from the legitimate person check?

> +    )
> +
> +
>  class AnnouncementMenuMixin:
>      """A mixin of links common to many menus."""
>  


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/438674
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:hide-make-announcement-link-illegitimate-pillar-owners into launchpad:master.