launchpad-reviewers team mailing list archive

[Simone <mp+439041@xxxxxxxxxxxxxxxxxx>]

Simone has proposed merging ~pelpsi/launchpad:mispelled-error-message-adding-yourself-team into launchpad:master.

Commit message:
Misspelled error message

Add yourself to a team by hitting "Add member" and then "Pick me", the error message if you're already a member was:
"Me is already a member of this team"
now is:
"<username> is already a member of this team"

LP: #1056790

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/439041
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:mispelled-error-message-adding-yourself-team into launchpad:master.

diff --git a/lib/lp/registry/javascript/team.js b/lib/lp/registry/javascript/team.js
index 65b64bb..517cc6b 100644
--- a/lib/lp/registry/javascript/team.js
+++ b/lib/lp/registry/javascript/team.js
@@ -54,7 +54,8 @@ var _add_member = function(selected_person) {
                 if (did_status_change === false) {
                     disable_spinner();
                     Y.lp.app.errors.display_info(
-                        selected_person.title + ' is already ' +
+                        selected_person.value +
+                        ' is already ' +
                         current_status.toLowerCase() +
                         ' as a member of the team.');
                     return;