launchpad-reviewers team mailing list archive

[Colin Watson <mp+439057@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:charm-only-amd64 into launchpad:master.

Commit message:
charm: Only build LP charms on amd64

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/439057

There's currently no particular reason to waste time and space building for other architectures, and building for s390x currently fails due to the `charm` snap being unavailable in the `2.x/stable` channel.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:charm-only-amd64 into launchpad:master.

diff --git a/charm/launchpad-admin/charmcraft.yaml b/charm/launchpad-admin/charmcraft.yaml
index f831b9f..507bbe3 100644
--- a/charm/launchpad-admin/charmcraft.yaml
+++ b/charm/launchpad-admin/charmcraft.yaml
@@ -3,9 +3,11 @@ bases:
   - build-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
     run-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
 parts:
   charm-wheels:
     source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels
diff --git a/charm/launchpad-appserver/charmcraft.yaml b/charm/launchpad-appserver/charmcraft.yaml
index 4f764a5..8b9bdda 100644
--- a/charm/launchpad-appserver/charmcraft.yaml
+++ b/charm/launchpad-appserver/charmcraft.yaml
@@ -3,9 +3,11 @@ bases:
   - build-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
     run-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
 parts:
   charm-wheels:
     source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels
diff --git a/charm/launchpad/charmcraft.yaml b/charm/launchpad/charmcraft.yaml
index ca6d9c8..0060a18 100644
--- a/charm/launchpad/charmcraft.yaml
+++ b/charm/launchpad/charmcraft.yaml
@@ -3,9 +3,11 @@ bases:
   - build-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
     run-on:
     - name: ubuntu
       channel: "20.04"
+      architectures: [amd64]
 parts:
   charm-wheels:
     source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels