launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+439077@xxxxxxxxxxxxxxxxxx>]

Have you noticed that Colin suggested to replace `p.distroseries.name` with `Version(p.distroseries.version)` in the relate bug in a comment?

If you plan to do otherwise, what are your reasons?

Also, while it seem daunting to find corresponding tests, there are a couple of strategies I use.

First, as you modify something in `product.py`, it is highly likely that there are unit tests in a `test_product.py` near the same location of the former file.

You are modifying the `translatable_packages` property, so the first I would do is search for that name in the above test file. If that does not show up, I would look where `translatable_packages` is used and then look for the corresponding tests.

Also, sometimes we do have doctests, which are a bit harder to find.

Running the whole test suite to find the correct tests is usually off limits except for the most severe changesets, as it takes so long ( 6 hours on my laptop, though mine seems to be on the slower end ).

tl/dr Although we do not measure test coverage, we seem to have a pretty high coverage. Please have a look whether you could create a test, and in case you need help, please do not hesitate to reach out.


-- 
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/439077
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:alphabetical-sort-orderd-unhelpful-codenames into launchpad:master.