← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~cjwatson/launchpad:remove-duplicate-grant into launchpad:master

 

Colin Watson has proposed merging ~cjwatson/launchpad:remove-duplicate-grant into launchpad:master.

Commit message:
Remove duplicate grant of sharingjob to launchpad role

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/439172

We already declare the same permissions on the `sharingjob` table for the `launchpad_main` role, and the `launchpad` role is a member of `launchpad_main`, so we don't need to declare this separately.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:remove-duplicate-grant into launchpad:master.
diff --git a/database/schema/security.cfg b/database/schema/security.cfg
index 49f2daf..0c97ba9 100644
--- a/database/schema/security.cfg
+++ b/database/schema/security.cfg
@@ -374,7 +374,6 @@ public.archivesubscriber                = SELECT, INSERT, UPDATE, DELETE
 public.hwsubmission                     = SELECT, INSERT, UPDATE, DELETE
 public.hwsubmissiondevice               = SELECT, DELETE
 public.karma                            = SELECT, INSERT, UPDATE, DELETE
-public.sharingjob                       = SELECT, INSERT, UPDATE, DELETE
 public.signedcodeofconduct              = SELECT, INSERT, UPDATE, DELETE
 
 [script]