launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+439337@xxxxxxxxxxxxxxxxxx>]

Simone Pelosi has proposed merging ~pelpsi/launchpad:new-API-endpoint-to-select-a-git-repository-by-id-readability into launchpad:master.

Commit message:
Improved readability

Changed from "id" to "ID" to improve readability

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/439337
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:new-API-endpoint-to-select-a-git-repository-by-id-readability into launchpad:master.

diff --git a/lib/lp/code/interfaces/gitrepository.py b/lib/lp/code/interfaces/gitrepository.py
index 31ed38b..7f6053f 100644
--- a/lib/lp/code/interfaces/gitrepository.py
+++ b/lib/lp/code/interfaces/gitrepository.py
@@ -1357,12 +1357,12 @@ class IGitRepositorySet(Interface):
         """
 
     @call_with(user=REQUEST_USER)
-    @operation_parameters(id=Int(title=_("Repository id"), required=True))
+    @operation_parameters(id=Int(title=_("Repository ID"), required=True))
     @operation_returns_entry(IGitRepository)
     @export_read_operation()
     @operation_for_version("devel")
     def getByID(user, id):
-        """Find a repository by its id.
+        """Find a repository by its ID.
 
         Return None if no match was found.
         """
diff --git a/lib/lp/code/model/tests/test_gitrepository.py b/lib/lp/code/model/tests/test_gitrepository.py
index 2b31131..d9c72b8 100644
--- a/lib/lp/code/model/tests/test_gitrepository.py
+++ b/lib/lp/code/model/tests/test_gitrepository.py
@@ -4802,14 +4802,14 @@ class TestGitRepositorySet(TestCaseWithFactory):
         verifyObject(IGitRepositorySet, self.repository_set)
 
     def test_getByID(self):
-        # getByID returns a repository matching the id that it's given.
+        # getByID returns a repository matching the ID that it's given.
         a = self.factory.makeGitRepository()
         self.factory.makeGitRepository()
         repository = self.repository_set.getByID(a.owner, a.id)
         self.assertEqual(a, repository)
 
     def test_getByID_not_found(self):
-        # If a repository cannot be found for a given id, then getById returns
+        # If a repository cannot be found for a given ID, then getById returns
         # None.
         a = self.factory.makeGitRepository()
         self.factory.makeGitRepository()