launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #29798
[Merge] ~cjwatson/launchpad:openpgp-keys-style-logged-out into launchpad:master
Colin Watson has proposed merging ~cjwatson/launchpad:openpgp-keys-style-logged-out into launchpad:master.
Commit message:
Fix OpenPGP key rendering when logged out
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1996775 in Launchpad itself: "OpenPGP keys field may overlap next field in a user profile"
https://bugs.launchpad.net/launchpad/+bug/1996775
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/439402
Commit 6820898dfc97d25e02daa35d5b4a71687d4e1419 only fixed the rendering of OpenPGP key fingerprints when logged in, because the `<a>` tag is omitted when logged out. Move the `style` attribute to an inner `<span>` tag to fix this.
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:openpgp-keys-style-logged-out into launchpad:master.
diff --git a/lib/lp/registry/templates/person-portlet-contact-details.pt b/lib/lp/registry/templates/person-portlet-contact-details.pt
index 9f7d054..02b55a7 100644
--- a/lib/lp/registry/templates/person-portlet-contact-details.pt
+++ b/lib/lp/registry/templates/person-portlet-contact-details.pt
@@ -141,9 +141,8 @@
<dd>
<tal:keys repeat="key view/gpg_keys">
<a tal:attributes="href key/keyserverURL"
- style="word-wrap: anywhere"
tal:omit-tag="not: request/lp:person">
- <tal:fingerprint replace="key/fingerprint"
+ <span style="word-wrap: anywhere" content="key/fingerprint"
/></a><span tal:condition="not: repeat/key/end">,</span>
</tal:keys>
<div tal:condition="not: view/gpg_keys">