← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ines-almeida/launchpad:update-getting-started-docs into launchpad:master

 


Diff comments:

> diff --git a/doc/how-to/running.rst b/doc/how-to/running.rst
> index 2f7e7ec..efbd73f 100644
> --- a/doc/how-to/running.rst
> +++ b/doc/how-to/running.rst
> @@ -125,6 +125,16 @@ installed and configured on your network.
>  
>      lxc launch ubuntu:16.04 lpdev -p default -p $USER
>  
> +
> +.. note::
> +   Ensure you have initialized your LXD storage. Run
> +
> +   .. code-block:: sh
> +
> +        lxd init
> +
> +   This should fix ``Error: No root device could be found`` errors you might get when running the command above.

Maybe turn this around a little so that it doesn't suggest that everyone will need to run this command at this point?  Something like "If this fails with ``Error: No root device could be found``, you may need to run ..."?

(Also, after this lands we'll need to manually tell readthedocs to rebuild.  If you could log into readthedocs.org and tell me your username there then I can add you to the Launchpad project.)

> +
>  3. Find the container IP, either from ``lxc list`` or ``lxc info lpdev``.
>  
>  4. In order to be able to ssh into the container, you need to add your


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/439933
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:update-getting-started-docs into launchpad:master.



Follow ups

References