launchpad-reviewers team mailing list archive

[Ines Almeida <mp+440064@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:update-wrapping-from-comment-boxes into launchpad:master.

Commit message:
Updated <p> width restriction and increased 'page-width' parameter

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/440064

Updated `lib/canonical/launchpad/icing/css/typography.scss` to remove max-width restriction for <p> text. Kept it for other components that had the same restriction.

Also updated the `page-width` scss parameter from 45em to 60em simply because it looks better imo. That parameter is only used in a few places.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:update-wrapping-from-comment-boxes into launchpad:master.

diff --git a/lib/canonical/launchpad/icing/css/typography.scss b/lib/canonical/launchpad/icing/css/typography.scss
index 1e58f29..27bb84d 100644
--- a/lib/canonical/launchpad/icing/css/typography.scss
+++ b/lib/canonical/launchpad/icing/css/typography.scss
@@ -1,6 +1,6 @@
 // This file the result of auto-converting typography.css to scss.
 
-$page-width: 45em;
+$page-width: 60em;
 $wider-page: $page-width + 15em;
 $reduced-spacing: 0.8em;
 $link-colour: #03a;
@@ -45,7 +45,7 @@ h1, h2, h3, h4, h5, h6 {
     margin-top: $reduced-spacing;
   }
 
-  p, li, dt, dd, blockquote, .narrow, .narrow-listing {
+  li, dt, dd, blockquote, .narrow, .narrow-listing {
     /* Wrap the text before the eye gets lost. */
     max-width: $page-width;
   }