launchpad-reviewers team mailing list archive

[Colin Watson <mp+441489@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad-layers:supermirror-root-trailing-slash into launchpad-layers:main.

Commit message:
Add trailing slash to supermirror_root

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #2017026 in launchpad-layers: "bazaar branch redirects missing slash between hostname and path"
  https://bugs.launchpad.net/launchpad-layers/+bug/2017026

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-layers/+git/launchpad-layers/+merge/441489

`lp.code.browser.branchref.BranchRefNavigation.traverse_branch` expects a trailing slash here, and generates broken URLs if it doesn't get one.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-layers:supermirror-root-trailing-slash into launchpad-layers:main.

diff --git a/launchpad-base/templates/launchpad-base-lazr.conf b/launchpad-base/templates/launchpad-base-lazr.conf
index 7f69d9b..71c456e 100644
--- a/launchpad-base/templates/launchpad-base-lazr.conf
+++ b/launchpad-base/templates/launchpad-base-lazr.conf
@@ -32,7 +32,7 @@ codehosting_endpoint: http://{{ domain_xmlrpc_private }}:{{ port_xmlrpc }}/codeh
 {{- opt("internal_bzr_api_endpoint", internal_bzr_api_endpoint) }}
 lp_url_hosts: {{ bzr_lp_url_hosts }}
 secure_codebrowse_root: https://{{ domain_bzr }}/
-supermirror_root: http://{{ domain_bzr }}
+supermirror_root: http://{{ domain_bzr }}/
 {%- endif %}
 {%- if domain_git %}
 internal_git_api_endpoint: http://{{ domain_git }}:19417/