launchpad-reviewers team mailing list archive

[Guruprasad <mp+441483@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/archivepublisher/scripts/publishdistro.py b/lib/lp/archivepublisher/scripts/publishdistro.py
> index 87e9a7d..58cfa5d 100644
> --- a/lib/lp/archivepublisher/scripts/publishdistro.py
> +++ b/lib/lp/archivepublisher/scripts/publishdistro.py
> @@ -475,6 +523,20 @@ class PublishDistro(PublisherScript):
>              self.options.enable_release
>              and publishing_method == ArchivePublishingMethod.LOCAL
>          ):
> +            if (
> +                config.archivepublisher.oval_data_rsync_endpoint
> +                and archive.is_ppa

Should we add a test for the non-PPA case?

> +                and dirty_suites
> +            ):
> +                for dirty_suite in dirty_suites:
> +                    updated = self.syncOVALDataFilesForSuite(
> +                        archive, dirty_suite
> +                    )
> +                    if updated:
> +                        self.logger.info(
> +                            "Synchronized the OVAL data for %s",
> +                            archive.reference,
> +                        )
>              publisher.D_writeReleaseFiles(
>                  self.isCareful(
>                      self.options.careful_apt or self.options.careful_release


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/441483
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:synchronize-oval-data-ppa-directory into launchpad:master.