launchpad-reviewers team mailing list archive

[Colin Watson <mp+442871@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:remove-packages-arch-specific-comments into launchpad:master.

Commit message:
Remove obsolete comments about Packages-arch-specific

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442871

"Packages-arch-specific", or "P-a-s", was an old system used to prevent certain packages from building on certain architectures.  As of commit a375e857d75f2572f9125517847607739a6cc985 in 2013 we no longer support this, so we can drop a few old comments about it that no longer make any sense.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:remove-packages-arch-specific-comments into launchpad:master.

diff --git a/lib/lp/soyuz/interfaces/publishing.py b/lib/lp/soyuz/interfaces/publishing.py
index 5b861a8..600f089 100644
--- a/lib/lp/soyuz/interfaces/publishing.py
+++ b/lib/lp/soyuz/interfaces/publishing.py
@@ -557,10 +557,6 @@ class ISourcePackagePublishingHistoryPublic(IPublishingView):
     def createMissingBuilds(architectures_available=None, logger=None):
         """Create missing Build records for a published source.
 
-        P-a-s should be used when accepting sources to the PRIMARY archive
-        (in drescher). It explicitly ignores given P-a-s for sources
-        targeted to PPAs.
-
         :param architectures_available: options list of `DistroArchSeries`
             that should be considered for build creation; if not given
             it will be calculated in place, all architectures for the
diff --git a/lib/lp/soyuz/scripts/packagecopier.py b/lib/lp/soyuz/scripts/packagecopier.py
index 8b62816..2e1557d 100644
--- a/lib/lp/soyuz/scripts/packagecopier.py
+++ b/lib/lp/soyuz/scripts/packagecopier.py
@@ -911,7 +911,6 @@ def _do_direct_copy(
 
     # Always ensure the needed builds exist in the copy destination
     # after copying the binaries.
-    # XXX cjwatson 2012-06-22 bug=869308: Fails to honour P-a-s.
     source_copy.createMissingBuilds(logger=logger)
 
     if move: